Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ERC1820 interface ids #21

Merged
merged 6 commits into from May 3, 2019

Conversation

nventuro
Copy link
Contributor

No description provided.

@nventuro nventuro requested a review from frangio March 26, 2019 23:59
@frangio
Copy link
Contributor

frangio commented Mar 27, 2019

I'm kind of reluctant to introduce this now because it's a breaking change and we just released a breaking change a couple weeks ago.

What do you think? It's true the library is in 0.x so a certain instability should be expected, but I don't feel that this feature is worth it.

@frangio
Copy link
Contributor

frangio commented Mar 27, 2019

We discussed offline that we're okay with being unstable in this early stage as long as we document the breaking changes and how to migrate from one version to the next.

@nventuro Can you add the changelog in this PR?

@frangio frangio assigned frangio and nventuro and unassigned frangio Apr 22, 2019
@nventuro nventuro requested review from frangio and removed request for frangio April 26, 2019 15:10
CHANGELOG.md Show resolved Hide resolved
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
@nventuro nventuro merged commit 3f5850f into OpenZeppelin:master May 3, 2019
@nventuro nventuro deleted the interface-ids branch May 3, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants