Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chai autoinstall #18

Merged
merged 8 commits into from Mar 19, 2019
Merged

Remove chai autoinstall #18

merged 8 commits into from Mar 19, 2019

Conversation

nventuro
Copy link
Contributor

With this change, chai needs to be explicitly required by users if they want to use it. Additionally, chai.should() is no longer called, which may have been a bit intrusive.

@nventuro nventuro requested a review from frangio March 19, 2019 19:03
@nventuro nventuro merged commit cb708ae into master Mar 19, 2019
@nventuro nventuro deleted the no-chai-magic branch March 19, 2019 20:11
@frangio frangio mentioned this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants