Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hope this project can continue #182

Open
fjun99 opened this issue Feb 21, 2022 · 3 comments
Open

hope this project can continue #182

fjun99 opened this issue Feb 21, 2022 · 3 comments

Comments

@fjun99
Copy link

fjun99 commented Feb 21, 2022

The helper in this project is very helpful.

Maybe we can continue to develop this project:

  • migrate it to ethers.js
  • add new handy helpers
@frangio
Copy link
Contributor

frangio commented Feb 22, 2022

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle. It should also have a lot fewer dependencies, particularly someone working with Ethers.js should not have to install Web3.js or Truffle and vice versa.

The testing setup is slow and overly complicated. I don't think we need to have this many integration tests.

If someone wants to work on this, that would be awesome.

@fjun99
Copy link
Author

fjun99 commented Feb 28, 2022

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle.

yes I agree. Typescript and ethers.

I adapted one or two js file in this project to ts for my own usage.

to work with

  • ethers.js
  • hardhat

@frangio
Copy link
Contributor

frangio commented Mar 4, 2022

I have started a potential rewrite of the project. So far expectRevert and snapshot are built. I would propose as next step expectEvent.

https://github.com/OpenZeppelin/openzeppelin-test-helpers/tree/rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants