Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now we've been having multiple issues with
solidity-coverage
. A bug I encountered yesterday broke the proverbial camel's back: when restoring a snapshot, account nonces are not restored, which causes issues with some deploy schemes, such as ERC1820's.This is an effort to migrate our testing infrastructure to 0x's
sol-coverage
, which will hopefully be more stable. Many changes needed to be made however, since it usesweb3-provider-engine
under the hood. I also had to move some contracts around, since 0x's tooling requires each contract to be stored in a file named after it.