Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiProofVerify #3276

Merged
merged 24 commits into from May 25, 2022
Merged

Add multiProofVerify #3276

merged 24 commits into from May 25, 2022

Conversation

colinh80
Copy link
Contributor

@colinh80 colinh80 commented Mar 21, 2022 •
edited

Fixes #3108

  • Added multiProofVerify, processMultiProof and _hashpair functions to MerkleProof.sol
  • Created MerkleMultiProofWrapper mock for test
  • Added tests for multiProofVerify to MerkleProof.test.js

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator

Amxx commented Mar 21, 2022

Thanks @colinjhicks for submitting this PR

@Amxx Amxx requested a review from frangio March 22, 2022 11:35
@Amxx
Copy link
Collaborator

Amxx commented Mar 22, 2022

We need a changelog entry for that

@Amxx
Copy link
Collaborator

Amxx commented Mar 23, 2022

Merge it please

We have a very strict process for merging code, which includes review and discussion among the team. Hope you understand.

Amxx
Amxx reviewed Mar 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Amxx Amxx mentioned this pull request Mar 25, 2022
Closed
1 task
@frangio frangio added this to the 4.7 milestone Mar 28, 2022
@JulissaDantes JulissaDantes changed the title Adding multiProofVerify Add multiProofVerify Apr 6, 2022
frangio
frangio approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amxx Amxx merged commit f8157ac into OpenZeppelin:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx left review comments

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.

Add multiProofVerify to MerkleProof.sol
3 participants
@colinh80 @Amxx @frangio