Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit ERC20Wrapper decimals from the underlying #3259

Merged
merged 2 commits into from Mar 22, 2022
Merged

Inherit ERC20Wrapper decimals from the underlying #3259

merged 2 commits into from Mar 22, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 10, 2022

Fixes #3258

PR Checklist

  • Tests
  • Changelog entry

@frangio
Copy link
Contributor

frangio commented Mar 10, 2022

Yes this makes sense to me.

@Amxx @frangio
Update test/token/ERC20/extensions/ERC20Wrapper.test.js
f58f39c 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@matthewdgreen matthewdgreen mentioned this pull request Mar 11, 2022
Closed
@Amxx Amxx enabled auto-merge (squash) March 22, 2022 08:55
@Amxx Amxx merged commit 9871617 into OpenZeppelin:master Mar 22, 2022
@Amxx Amxx deleted the fix/ERC20/wrapper/decimals branch March 22, 2022 08:56
@Amxx Amxx mentioned this pull request Mar 22, 2022
Merged
1 task
Amxx added a commit that referenced this pull request Mar 22, 2022
@Amxx @frangio
Add changelog entry for #3259 (#3281)
c028c56 
* improve wrapper decimal support

* Update test/token/ERC20/extensions/ERC20Wrapper.test.js

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>

* add changelog entry

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20Wrapper does not pass through underlying token's decimals()
2 participants
@Amxx @frangio