Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Governor module for governance-settable parameters #2904

Merged
merged 26 commits into from Oct 19, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 6, 2021

Fixes #2903
Fixes #2866

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio frangio mentioned this pull request Oct 6, 2021
1 task
@frangio frangio changed the title GovernorSettings Add Governor module for governance-settable parameters Oct 6, 2021
@Amxx
Copy link
Collaborator Author

Amxx commented Oct 6, 2021

Note: this PR does change the governor's interfaceId

@frangio
Copy link
Contributor

frangio commented Oct 13, 2021

Note: this PR does change the governor's interfaceId

This doesn't sound good... The interface id is already being depended on, I don't think we can change it.

@Amxx
Copy link
Collaborator Author

Amxx commented Oct 13, 2021

Whould that be good ?

    function supportsInterface(bytes4 interfaceId) public view virtual override(IERC165, ERC165) returns (bool) {
        // In addition to the current interfaceId, also support previous version of the interfaceId that did not
        // include the proposalThreshold() function as standard
        return interfaceId == (type(IGovernor).interfaceId ^ this.proposalThreshold.selector)
            || interfaceId == type(IGovernor).interfaceId
            || super.supportsInterface(interfaceId);
    }

@apbendi
Copy link
Contributor

apbendi commented Oct 13, 2021

hey @Amxx, just curious about the state of this PR and when we might expect it to land. Thanks!

@Amxx
Copy link
Collaborator Author

Amxx commented Oct 13, 2021

Soon :)

@Amxx Amxx requested a review from frangio October 13, 2021 21:09
@frangio
Copy link
Contributor

frangio commented Oct 14, 2021

@apbendi To be a little more specific this will land in 4.4, which will have a release candidate out in the next several days. The final release will come a few weeks later than that.

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@frangio frangio merged commit b12af48 into OpenZeppelin:master Oct 19, 2021
@Amxx Amxx deleted the feature/governance-settings branch October 20, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Governance Updatable Governance Params Governor module for governance-settable parameters
3 participants