Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay the Pending state until strictly after proposal.voteStart #2892

Merged
merged 10 commits into from Oct 6, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 30, 2021

Delay the Pending state until strictly after proposal.voteStart to avoid issue with potential invalid implementations of the voting token

Fixes #2886

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

issue with potential invalid implementations of the voting token
@frangio frangio mentioned this pull request Oct 4, 2021
1 task
@frangio
Copy link
Contributor

frangio commented Oct 6, 2021

Missing a changelog entry. "Delayed Governor vote start and end by one block"?

@Amxx Amxx requested a review from frangio October 6, 2021 19:49
@Amxx Amxx self-assigned this Oct 6, 2021
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit abeb0fb into OpenZeppelin:master Oct 6, 2021
@Amxx Amxx deleted the fix/extra-pending-security branch October 12, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Governor state
2 participants