ERC1155
: reorder of KeyType
s in _balances
#5023
Labels
breaking change
Changes that break backwards compatibility of the public API.
It might be nit, but you define
_balances
in yourERC1155
implementation accordingly:but the
balanceOf
function uses the (switched) EIP-1155-compliant way as function arguments:I would propose to change
_balances
to:in order to avoid confusion and to keep consistency with the
balanceOf
function. My guess, why it has been implemented like this in OZ, is the official EIP implementation here.The text was updated successfully, but these errors were encountered: