Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test non-commutative internal node hashing functions in MerkleTree and Merkle Proof #4945

Open
ernestognw opened this issue Mar 7, 2024 · 0 comments
Open

Test non-commutative internal node hashing functions in MerkleTree and Merkle Proof #4945

ernestognw opened this issue Mar 7, 2024 · 0 comments
Labels
tests Test suite and helpers.

Comments

@ernestognw
Copy link
Member

ernestognw commented Mar 7, 2024 •
edited

In both MerkleTree and MerkleProof, we're currently using the Hashes.commutativeKeccak256. Ideally, we would test for non-commutative hashing functions before releasing and when the Javascript Library for merkle trees is released
@Amxx Amxx added the tests Test suite and helpers. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amxx @ernestognw