Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding an ESLint rule for no async in describe blocks #4943

Open
ernestognw opened this issue Mar 6, 2024 · 0 comments
Open

Consider adding an ESLint rule for no async in describe blocks #4943

ernestognw opened this issue Mar 6, 2024 · 0 comments
Labels
tests Test suite and helpers.

Comments

@ernestognw
Copy link
Member

ernestognw commented Mar 6, 2024 •
edited

From @fvictorio:

I forgot to mention:

  • The wrong async keywords in describe functions can be prevented with this rule.
  • The missing await keywords are harder. Ideally you'd use typescript and the no-floating-promises rule, but I understand that that would be a huge undertaking.

Originally posted by @fvictorio in #4942 (comment)

We're considering adding only the ESLint rule and not migrating to Typescript to catch floating promises. However, we're open to alternatives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amxx @ernestognw