Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI check that custom errors are not declared multiple times through the repo. #4331

Open
Amxx opened this issue Jun 9, 2023 · 1 comment · May be fixed by #4549
Open

Add a CI check that custom errors are not declared multiple times through the repo. #4331

Amxx opened this issue Jun 9, 2023 · 1 comment · May be fixed by #4549
Labels
tooling
Milestone
5.0

Comments

@Amxx
Copy link
Collaborator

Amxx commented Jun 9, 2023

Guidelines introduces in #4261 says:

Custom error names should not be declared twice along the library to avoid duplicated identifier declarations when inheriting from multiple contracts.

We should have an automated check for that.
@Amxx Amxx added this to the 5.0 milestone Jun 9, 2023
@Amxx Amxx added the tooling label Jun 9, 2023
@mw2000
Copy link
Contributor

mw2000 commented Jun 11, 2023 •
edited

@Amxx Assuming we should have some sort of shell script that the CI pipeline will call which does this check?

@0xVolosnikov 0xVolosnikov linked a pull request Aug 29, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling
Projects
None yet
Milestone
5.0
2 participants
@Amxx @mw2000