Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show if event parameter is indexed in docs #3958

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

JulissaDantes
Copy link
Contributor

Fixes an issue in the docs repo #311

The documentation is rendered without showing if an event parameter was indexed or not. This PR modifies the existing helper to consider if indexed too.

To check how it would show run nom run docs:watch

Result:
Screen Shot 2023-01-16 at 10 31 56 AM

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@JulissaDantes JulissaDantes added the documentation Inline comments, guides, and examples. label Jan 16, 2023
@JulissaDantes JulissaDantes marked this pull request as ready for review January 16, 2023 14:39
@frangio frangio changed the title Show is event parameter is indexed Show if event parameter is indexed in docs Jan 16, 2023
docs/templates/helpers.js Outdated Show resolved Hide resolved
docs/templates/helpers.js Outdated Show resolved Hide resolved
JulissaDantes and others added 2 commits January 16, 2023 11:41
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frangio frangio merged commit 18691d1 into OpenZeppelin:master Jan 16, 2023
frangio pushed a commit that referenced this pull request Jan 16, 2023
Co-authored-by: Francisco <frangio.1@gmail.com>
(cherry picked from commit 18691d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants