Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ERC721Holder & ERC1155Holder for Governor, Timelock #3936

Closed
frangio opened this issue Jan 7, 2023 · 1 comment · Fixed by #4284
Closed

Use ERC721Holder & ERC1155Holder for Governor, Timelock #3936

frangio opened this issue Jan 7, 2023 · 1 comment · Fixed by #4284
Milestone
5.0

Comments

@frangio
Copy link
Contributor

frangio commented Jan 7, 2023

As discussed before in #3174, the Governor and TimelockController contracts are able to receive ERC721 and ERC1155 tokens, so they should implement the respective Receiver interfaces. This was fixed in #3230, but due to storage layout compatibility (#3174 (comment)) we didn't use ERC721Holder and ERC1155Holder. We should do that now.
@frangio frangio added this to the 5.0 milestone Jan 7, 2023
@kimanikelly
Copy link
Contributor

@frangio Is this issue still relevant to be picked up? If so, I'd be glad to start working on it

@Amxx Amxx mentioned this issue May 26, 2023
Merged
3 tasks
@frangio frangio mentioned this issue May 31, 2023
Merged
72 tasks
@clauBv23 clauBv23 mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Use ERC721Holder & ERC1155Holder in the TimelockController Amxx/openzeppelin-contracts
2 participants
@frangio @kimanikelly