Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_requireMinted() is in master but is not in v4.6 #3494

Closed
oksusu12 opened this issue Jun 20, 2022 · 3 comments
Closed

_requireMinted() is in master but is not in v4.6 #3494

oksusu12 opened this issue Jun 20, 2022 · 3 comments

Comments

@oksusu12
Copy link

For contracts/token/ERC721/ERC721.sol, it seems to be that _requireMinted() function was introduced in v.4.7.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v4.7/contracts/token/ERC721/ERC721.sol
has requireMinted()
but https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v4.6/contracts/token/ERC721/ERC721.sol
does not have requireMinted().

in master branch:
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/ERC721.sol
The second line says that it is last updated v.4.6.
// OpenZeppelin Contracts (last updated v4.6.0) (token/ERC721/ERC721.sol)
But it doesn't have requireMinted().

Is this expected?
I assumed that it was a minor bug in master branch. Should be
// OpenZeppelin Contracts (last updated v4.7.0) (token/ERC721/ERC721.sol)

@Amxx
Copy link
Collaborator

Amxx commented Jun 21, 2022

_requireMinted() was introduced in #3438, which is part of 4.7

It was not part of 4.6 or any other version before that.

The last updated message is updated when a version is fully released. 4.7 is still a release candidate, and was not yet merged back in the master, so the last updated message was not yet updated on master.

@Amxx Amxx closed this as completed Jun 21, 2022
@0xmstore
Copy link

@Amxx one of my ERC721 contracts does not have the _requireMinted() function yet does that pose a malicious risk to the contract? or this just for clarity? Thanks I'll be anticipating your response.

@Amxx
Copy link
Collaborator

Amxx commented Aug 19, 2022

That is not a security concern. Don't worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants