Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of signature+calldata in GovernorCompatibilityBravo #3100

Merged
merged 6 commits into from Jan 11, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 10, 2022

Fixes #3099

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx mentioned this pull request Jan 10, 2022
@Amxx Amxx requested a review from frangio January 10, 2022 15:52
@frangio frangio changed the title fixing the way signature+calldata are encoded in the compatibility layer Fix encoding of signature+calldata in GovenorCompatibilityBravo Jan 10, 2022
test/governance/GovernorWorkflow.behavior.js Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
frangio
frangio previously approved these changes Jan 11, 2022
@frangio frangio changed the title Fix encoding of signature+calldata in GovenorCompatibilityBravo Fix encoding of signature+calldata in GovernorCompatibilityBravo Jan 11, 2022
@frangio frangio merged commit c366de3 into OpenZeppelin:master Jan 11, 2022
frangio pushed a commit to frangio/openzeppelin-contracts that referenced this pull request Jan 11, 2022
…nZeppelin#3100)

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
(cherry picked from commit c366de3)
@Amxx Amxx deleted the fix/GovernorCompatibilityEncoding branch January 11, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GovernorCompatibilityBravo encodes calldata incorrectly
2 participants