Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20Votes: Emit DelegateVotesChanged events after the corresponding Transfer #2733

Merged
merged 1 commit into from Jun 22, 2021
Merged

ERC20Votes: Emit DelegateVotesChanged events after the corresponding Transfer #2733

merged 1 commit into from Jun 22, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 21, 2021

In order to match Compound's interface, DelegateVotesChanged must be triggered after the transfer event has been emitted.

This is fixes using a new _afterTokenTransfer hook

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx changed the title Emit DelegateVotesChanged events after the corresponding Transfer ERC20Votes: Emit DelegateVotesChanged events after the corresponding Transfer Jun 21, 2021
frangio
frangio approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio merged commit 8a775cd into OpenZeppelin:master Jun 22, 2021
@Amxx Amxx deleted the feature/ERC20Votes/DelegateAfterTransfer branch June 23, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amxx @frangio