Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF url not ending with .pdf will break schema validation #900

Open
martinratinaud opened this issue Aug 16, 2022 · 1 comment
Open

PDF url not ending with .pdf will break schema validation #900

martinratinaud opened this issue Aug 16, 2022 · 1 comment

Comments

@martinratinaud
Copy link
Member

I had to bypass this by adding a weird ?.pdf at the end of the file on this https://github.com/OpenTermsArchive/p2b-compliance-declarations/pull/75/files

A potential solution would be to make a HEAD axios request during the validation process
@MattiSG
Copy link
Member

MattiSG commented Aug 17, 2022

Thanks for creating an issue! I'm quite sure we already encountered this problem (in France maybe?), but I can't find a trace of it.

@MattiSG MattiSG mentioned this issue Apr 24, 2023
Closed
@MattiSG MattiSG mentioned this issue Mar 4, 2024
Merged
Kissaki added a commit to Kissaki/contrib-declarations that referenced this issue Mar 4, 2024
@Kissaki
Add 'Alpha Vantage' ToS and PP declarations
2e42544 
Both URLs respond with a PDF response => no selectors

Uses `?.pdf` as a workaround for lint not supporting arbitrary URLs for PDFs

OpenTermsArchive/engine#900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattiSG @martinratinaud