Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of ota lint doesn't seem to point out location of Invalid URLs it finds #1067

Open
michielbdejong opened this issue Apr 2, 2024 · 2 comments

Comments

@michielbdejong
Copy link
Contributor

In tosdr/tosdr-declarations#12 (comment) we see an ota lint failure, but running it locally I see:

 npm run lint

> lint
> ota lint


  1) Uncaught error outside test suite

  0 passing (1ms)
  1 failing

  1) Uncaught error outside test suite:
     Uncaught TypeError: Invalid URL
      at new URL (node:internal/url:775:36)
      at new SourceDocument (file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/src/archivist/services/sourceDocument.js:10:15)
      at loadServiceDocument (file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/src/archivist/services/index.js:66:26)
      at async Promise.all (index 0)
      at async file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/src/archivist/services/index.js:28:5
      at async Promise.all (index 37)
      at async load (file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/src/archivist/services/index.js:23:3)
      at async Module.loadWithHistory (file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/src/archivist/services/index.js:101:20)
      at async default (file:///Users/michiel/gh/tosdr/tosdr-declarations/node_modules/@opentermsarchive/engine/scripts/declarations/lint/index.mocha.js:25:31)

And no further info. Does this lint tool have something like a verbose version where it tells you the location of the Invalid URL it finds?

@michielbdejong
Copy link
Contributor Author

See comment in MatterMost from @Ndpnt

@MattiSG
Copy link
Member

MattiSG commented Apr 9, 2024

Said comment unblocks the specific case through tosdr/tosdr-declarations#14, and also states:

We already planned to work on improving the validation tooling. However, it will take a few weeks for these enhancements to be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants