Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setup of autocrlf on Windows #1018

Open
MattiSG opened this issue Aug 29, 2023 · 3 comments
Open

Document setup of autocrlf on Windows #1018

MattiSG opened this issue Aug 29, 2023 · 3 comments
Assignees

Comments

@MattiSG
Copy link
Member

MattiSG commented Aug 29, 2023

autocrlf is set to false both in the CI workflow and in the Git adapter setup.

The latter seems much more reliable, and I worry that the CI setup gives us a false sense of security when our tests run on specifically-configured machines.

Do we really need the CI setup?

@MattiSG
Copy link
Member Author

MattiSG commented Aug 29, 2023

Beyond this specific case, adding a comment explaining why this setup is needed would be very useful.

@Ndpnt
Copy link
Member

Ndpnt commented Feb 12, 2024

I tried to remove it from the CI workflow configuration but it does not work. See https://github.com/OpenTermsArchive/engine/actions/runs/7831447577/job/21369769402

@MattiSG
Copy link
Member Author

MattiSG commented Feb 12, 2024

Thanks. This thus seems to be needed for Windows, no matter the Git adapter setup. I understand that this should thus be documented for users on Windows.

@MattiSG MattiSG changed the title Potential duplication of autocrlf set to false Document setup of autocrlf on Windows Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants