Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid detection of empty events array in update notification #6582

Open
wetneb opened this issue May 1, 2024 · 0 comments
Open

Invalid detection of empty events array in update notification #6582

wetneb opened this issue May 1, 2024 · 0 comments
Assignees
@wetneb
Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented May 1, 2024

In OpenRefine 3.8.0, when accepting the update notifications, the current code does not handle correctly the case where https://openrefine.org/versions.json contains events: []. It displays an empty yellow bubble at the top of the screen:

image

I'm fixing the problem by removing this field from the versions.json file but it would be better if OpenRefine checked properly for the existence and non-emptiness of this array.
@wetneb wetneb added the Type: Bug Issues related to software defects or unexpected behavior, which require resolution. label May 1, 2024
@wetneb wetneb self-assigned this May 1, 2024
wetneb added a commit to OpenRefine/openrefine.org that referenced this issue May 1, 2024
@wetneb
Fix empty release notification for OpenRefine 3.8.0
f7b92cc 
OpenRefine/OpenRefine#6582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wetneb