Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata and Wikibase reconciliation services don't load in OpenRefine 3.8.0 #6580

Open
trnstlntk opened this issue May 1, 2024 · 5 comments
Labels
Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@trnstlntk
Copy link
Contributor

Wikidata and Wikibase reconciliation services don't load in OpenRefine 3.8.0. I have seen this on my mac (in Chrome, Firefox) and it has been reported on OpenRefine on PAWS too. On my partner's PC it did work.

Reconciliation does work with various non-Wikibase reconciliation services and with the Wikimedia Commons one. It doesn't work with Wikidata's and with a few Wikibases' I've tried (at least I think they are Wikibases - Kunstmuseum.nl and the EU knowledge graph)

The recon window doesn't appear to load anything
image

In the terminal log, nothing happens (nothing is logged) when doing the reconciliation steps.

This is what I get in the browser console.
image

@trnstlntk trnstlntk added Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Bug Issues related to software defects or unexpected behavior, which require resolution. labels May 1, 2024
@trnstlntk
Copy link
Contributor Author

Removing and re-adding the reconciliation services doesn't fix this issue.

@wetneb
Copy link
Sponsor Member

wetneb commented May 1, 2024

This seems to be caused by the presence of the Commons extension, which embeds a copy of suggest-4_3a.js which conflicts with the version we have in OpenRefine. Removing the extension (until a new fixed version is released) should probably solve the problem.

@trnstlntk
Copy link
Contributor Author

I can confirm that removing the Commons extension fixes this issue. Thanks!

@sebastian-berlin-wmse
Copy link

Removing the files in module/externals/suggest/ fixes this. However, it looks like it also breaks the extension. I had to go back to 3.7.9 because of #6581, but then you get the error below and clicking on Wikimedia Commons in the source list doesn't do anything.

16:02:35.547 Uncaught TypeError: $.suggest is undefined
    <anonymous> http://127.0.0.1:3333/index-bundle.js:74285
    <anonymous> http://127.0.0.1:3333/index-bundle.js:74403
index-bundle.js:74285:7
16:02:37.050 Uncaught TypeError: tr.find(...).suggestCategory is not a function
    addRow http://127.0.0.1:3333/index-bundle.js:74207
    attachUI http://127.0.0.1:3333/index-bundle.js:74235
    addSourceSelectionUI http://127.0.0.1:3333/index-bundle.js:64550
    CommonsImportingController http://127.0.0.1:3333/index-bundle.js:73843
    _initializeUI http://127.0.0.1:3333/index-bundle.js:64529
    CreateProjectUI http://127.0.0.1:3333/index-bundle.js:64509
    fire http://127.0.0.1:3333/index-bundle.js:3502
    fireWith http://127.0.0.1:3333/index-bundle.js:3632
    done http://127.0.0.1:3333/index-bundle.js:9824
    callback http://127.0.0.1:3333/index-bundle.js:10085
    send http://127.0.0.1:3333/index-bundle.js:10137
    ajax http://127.0.0.1:3333/index-bundle.js:9718
    <anonymous> http://127.0.0.1:3333/index-bundle.js:11293
    prop http://127.0.0.1:3333/index-bundle.js:11095
    _getAllProjectTags http://127.0.0.1:3333/index-bundle.js:65657
    _buildTagsListPanel http://127.0.0.1:3333/index-bundle.js:64837
    _buildTagsAndFetchProjects http://127.0.0.1:3333/index-bundle.js:64831
    OpenProjectUI http://127.0.0.1:3333/index-bundle.js:64801
    renderActionArea http://127.0.0.1:3333/index-bundle.js:64424
    <anonymous> http://127.0.0.1:3333/index-bundle.js:64428
    mightThrow http://127.0.0.1:3333/index-bundle.js:3768
    process http://127.0.0.1:3333/index-bundle.js:3836
index-bundle.js:74207:39

@sebastian-berlin-wmse
Copy link

I've started investigating how scripts are bundled and it looks like suggest-4_3a.js is added to the project/scripts bundle. It looks like it shouldn't be if you look in controller.js so something strange seems to be going on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

No branches or pull requests

3 participants