New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wikibase: Better handling of the 'badtags' error #6552
base: master
Are you sure you want to change the base?
Conversation
@sebastian-berlin-wmse and @Vesihiisi have tested it and it works, but in the case of media upload this has the bad side effect of uploading the file twice if the first upload fails because of a bad tag. It would be more efficient if we could avoid this double upload. Note that this would only happen for the first upload in a batch, because OpenRefine keeps using the latest tag that worked afterwards. One approach would be to upload without tags and then apply the tags manually. Perhaps that would be a better architecture, although it might also have downsides:
Also Wikidata-Toolkit doesn't have a wrapper for applying tags to an edit so we'd need to make the request ourselves (but that wouldn't be the first time). At least we should update the manifests so that new users get the right (unversioned) tag. |
Actually, the |
This falls back on editing with a non-versioned 'openrefine' tag instead of 'openrefine-${version}" by default, and on editing without a tag if 'openrefine' isn't available. Closes OpenRefine#6551.
e71ed3f
to
9e5c9f9
Compare
I'd merge this next week unless there are any concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about Wikibase to offer an opinion.
This falls back on editing with a non-versioned
openrefine
tag instead ofopenrefine-${version}
by default, and on editing without a tag ifopenrefine
isn't available.Closes #6551.