New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SVG logo and icons instead of png #6316
Comments
If you check the version from the master branch, I think we have at least changed the top logo to not include the text (@Abbe98 did this, I don't have the PR number at hand). If the logo is still in PNG and not SVG there, then I'd say it's totally worth migrating indeed. Would you be interested in working on that? |
Hello @wetneb Stupid question but what do you mean by working on that ? I thought the svg logo already exists ? Best regards, Simon |
By the way, I had a look at the main branch https://github.com/OpenRefine/OpenRefine/tree/master/main/webapp/modules/core/images All png. I'm not even sure they're all used |
I also found that article about animated svg to replace gig |
@simonaubertbd by "working on that", I mean doing the necessary changes in OpenRefine's source code so that the SVG image is used instead of the PNG one. You would then open a pull request for us to review your changes, and after merging the pull request, the next OpenRefine release would not have the problem that you describe: it would use the SVG logos. Here is an overview of the contribution process (with a lot of steps not being necessary in such a simple case): |
I marked this as a good first issue, to replace the OpenRefine logo from a PNG to SVG. There are many other raster images in the UI, which would totally deserve being migrated to SVGs as well, but let's keep this issue focused on the OpenRefine logos mentioned above. |
@wetneb I would like to work on it. Can I? |
@vr-varad Are you still working on this issue? If not, can I get this assigned ? |
I think two weeks is more than enough time to tackle something like this, so go ahead @abhishekkujur1307! |
@wetneb I am not able to find svg logo for this image. If there is, please send me the location of svg file or svg link. Edit: Or maybe I can use some image to vector convertor tool, incase, there is no svg ? |
If you try OpenRefine from the master branch (not the latest stable release), you'll see that the image only covers the logo now, as @Abbe98 has already taken care of converting the "OpenRefine" text part to an actual text. |
@abhishekkujur1307 are you still working on this issue? if not I'm looking for a good first issue to tackle and I'd like to give it a try |
@wetneb Please de-assign me. I am sick and will not be able to contribute. |
Automatically unassigned after 45 days of inactivity. |
Hello,
I was very surprised to see OpenRefine still use a png image for its logos displayed in the application
SVG (vector image format) are great : fast, light, can resize easily, etc.. and work perfectly in a web browser. Moreover, it's not a lot of work since the logo is already available in svg
https://fr.wikipedia.org/wiki/OpenRefine#/media/Fichier:OpenRefine_favicon_(2018-present).svg
Proposed solution
To use svg version of these pictures
Alternatives considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: