Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG logo and icons instead of png #6316

Open
simonaubertbd opened this issue Jan 17, 2024 · 14 comments · May be fixed by #6491 or #6620
Open

Use SVG logo and icons instead of png #6316

simonaubertbd opened this issue Jan 17, 2024 · 14 comments · May be fixed by #6491 or #6620
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Theme: UI/Visual Issues that focus on improving the visual aesthetics, layout, and typography of the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.

Comments

@simonaubertbd
Copy link

Hello,
I was very surprised to see OpenRefine still use a png image for its logos displayed in the application
image

image

SVG (vector image format) are great : fast, light, can resize easily, etc.. and work perfectly in a web browser. Moreover, it's not a lot of work since the logo is already available in svg
https://fr.wikipedia.org/wiki/OpenRefine#/media/Fichier:OpenRefine_favicon_(2018-present).svg

Proposed solution

To use svg version of these pictures

Alternatives considered

N/A

Additional context

N/A

@simonaubertbd simonaubertbd added Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. labels Jan 17, 2024
@wetneb
Copy link
Sponsor Member

wetneb commented Jan 17, 2024

If you check the version from the master branch, I think we have at least changed the top logo to not include the text (@Abbe98 did this, I don't have the PR number at hand).

If the logo is still in PNG and not SVG there, then I'd say it's totally worth migrating indeed. Would you be interested in working on that?

@simonaubertbd
Copy link
Author

Hello @wetneb Stupid question but what do you mean by working on that ? I thought the svg logo already exists ?
OpenRefine logo (2018)

Best regards,

Simon

@simonaubertbd
Copy link
Author

By the way, I had a look at the main branch https://github.com/OpenRefine/OpenRefine/tree/master/main/webapp/modules/core/images

All png. I'm not even sure they're all used

@simonaubertbd
Copy link
Author

I also found that article about animated svg to replace gig
https://arsiriy.com/2021/02/21/animated-svg-vs-gif/

@wetneb
Copy link
Sponsor Member

wetneb commented Jan 18, 2024

@simonaubertbd by "working on that", I mean doing the necessary changes in OpenRefine's source code so that the SVG image is used instead of the PNG one. You would then open a pull request for us to review your changes, and after merging the pull request, the next OpenRefine release would not have the problem that you describe: it would use the SVG logos.

Here is an overview of the contribution process (with a lot of steps not being necessary in such a simple case):
https://openrefine.org/docs/technical-reference/code-contributions

@wetneb wetneb added Theme: UI/Visual Issues that focus on improving the visual aesthetics, layout, and typography of the user interface. Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Mar 10, 2024
@wetneb
Copy link
Sponsor Member

wetneb commented Mar 10, 2024

I marked this as a good first issue, to replace the OpenRefine logo from a PNG to SVG. There are many other raster images in the UI, which would totally deserve being migrated to SVGs as well, but let's keep this issue focused on the OpenRefine logos mentioned above.

@vr-varad
Copy link

@wetneb I would like to work on it. Can I?

@abhishekkujur1307
Copy link
Contributor

@vr-varad Are you still working on this issue? If not, can I get this assigned ?

@wetneb wetneb assigned abhishekkujur1307 and unassigned vr-varad Mar 21, 2024
@wetneb
Copy link
Sponsor Member

wetneb commented Mar 21, 2024

I think two weeks is more than enough time to tackle something like this, so go ahead @abhishekkujur1307!

@abhishekkujur1307
Copy link
Contributor

abhishekkujur1307 commented Mar 22, 2024

@wetneb I am not able to find svg logo for this image.
image

If there is, please send me the location of svg file or svg link.

Edit: Or maybe I can use some image to vector convertor tool, incase, there is no svg ?

@wetneb
Copy link
Sponsor Member

wetneb commented Mar 23, 2024

If you try OpenRefine from the master branch (not the latest stable release), you'll see that the image only covers the logo now, as @Abbe98 has already taken care of converting the "OpenRefine" text part to an actual text.
So you should only need to replace the logo itself by the SVG linked above.

@JasonZelmanovich
Copy link

@abhishekkujur1307 are you still working on this issue? if not I'm looking for a good first issue to tackle and I'd like to give it a try

@abhishekkujur1307
Copy link
Contributor

@wetneb Please de-assign me. I am sick and will not be able to contribute.

Copy link

Automatically unassigned after 45 days of inactivity.

@xinluz6 xinluz6 linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Theme: UI/Visual Issues that focus on improving the visual aesthetics, layout, and typography of the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
5 participants