Skip to content

Fix mypy errors with no_implicit_optional=True #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

schlenk
Copy link
Collaborator

@schlenk schlenk commented Nov 11, 2022

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

Sorry, something went wrong.

@schlenk schlenk changed the title [WIP] Try fixing mypy errors with no_implicit_optional=True Fix mypy errors with no_implicit_optional=True Nov 11, 2022
@schlenk schlenk requested a review from tpazderka November 11, 2022 19:25
@schlenk schlenk force-pushed the mypy_implicit_optional branch from 4e3d217 to 31d6d33 Compare November 12, 2022 10:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #832 (c1f79da) into master (954ee64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   63.76%   63.77%           
=======================================
  Files          64       64           
  Lines       11882    11883    +1     
  Branches     2159     2159           
=======================================
+ Hits         7577     7578    +1     
  Misses       3700     3700           
  Partials      605      605           
Impacted Files Coverage Δ
src/oic/oauth2/provider.py 70.70% <ø> (ø)
src/oic/oic/__init__.py 64.99% <ø> (ø)
src/oic/oic/provider.py 74.07% <ø> (ø)
src/oic/oauth2/__init__.py 69.95% <100.00%> (ø)
src/oic/oauth2/base.py 55.40% <100.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schlenk schlenk merged commit 2ebab0f into master Nov 13, 2022
@schlenk schlenk deleted the mypy_implicit_optional branch November 13, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants