Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content-Type for backchannel logout POSTs #712

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

rohe
Copy link
Collaborator

@rohe rohe commented Nov 13, 2019

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

According to spec the POST body uses the application/x-www-form-urlencoded encoding.

Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run black on the code in order for quality to pass.

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f67df35). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #712   +/-   ##
=========================================
  Coverage          ?   63.83%           
=========================================
  Files             ?       63           
  Lines             ?    11684           
  Branches          ?     2053           
=========================================
  Hits              ?     7459           
  Misses            ?     3656           
  Partials          ?      569
Impacted Files Coverage Δ
src/oic/oic/provider.py 74.78% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67df35...2352bed. Read the comment docs.

@tpazderka
Copy link
Collaborator

Failing CI is because of #714, will be dealt with there...

@tpazderka tpazderka merged commit ddeb42d into master Nov 13, 2019
@tpazderka tpazderka deleted the content_type branch November 13, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants