Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no post_logout_redirect_uri #711

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Allow no post_logout_redirect_uri #711

merged 1 commit into from
Nov 13, 2019

Conversation

rohe
Copy link
Collaborator

@rohe rohe commented Nov 12, 2019

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

If no post_logout_redirect_uris are registered and no post_logut_redirect_uri appears in the
request, the user will be redirect to a post logout uri defined by the OP.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #711 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   63.83%   63.77%   -0.07%     
==========================================
  Files          63       63              
  Lines       11683    11688       +5     
  Branches     2053     2056       +3     
==========================================
- Hits         7458     7454       -4     
- Misses       3656     3662       +6     
- Partials      569      572       +3
Impacted Files Coverage Δ
src/oic/oic/provider.py 74.31% <100%> (-0.45%) ⬇️
src/oic/oic/message.py 69.52% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27feaf8...a1c79b0. Read the comment docs.

src/oic/oic/provider.py Outdated Show resolved Hide resolved
src/oic/oic/provider.py Outdated Show resolved Hide resolved
src/oic/oic/provider.py Outdated Show resolved Hide resolved
src/oic/oic/provider.py Show resolved Hide resolved
In the case where no post_logout_redirect_uris are registered
and no post_logout_uri appears in the request after the logout
is verified send the user to a default logout page.
If no default is specified, display an error page.
@tpazderka
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@tpazderka
Copy link
Collaborator

Failing CI is because of #714, will be dealt with there...

@tpazderka tpazderka merged commit f67df35 into master Nov 13, 2019
@tpazderka tpazderka deleted the post_logout branch November 13, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants