Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'state' in kwargs MUST NOT overwrite 'state' in request_args. #698

Merged
merged 4 commits into from
Oct 18, 2019

Conversation

rohe
Copy link
Collaborator

@rohe rohe commented Oct 18, 2019

'state' in kwargs is used as a key to access information in the RP.
'state' in request_args is just a request argument.
They are not necessarily the same.

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

'state' in kwargs is used as a key to access information in the RP.
'state' in request_args is just a request argument.
They are not necessarily the same.
@rohe
Copy link
Collaborator Author

rohe commented Oct 18, 2019

The errors in travis-ci is not of my doing.

@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #698 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage    62.8%   62.82%   +0.01%     
==========================================
  Files          63       63              
  Lines       11521    11519       -2     
  Branches     2031     2030       -1     
==========================================
+ Hits         7236     7237       +1     
+ Misses       3705     3703       -2     
+ Partials      580      579       -1
Impacted Files Coverage Δ
src/oic/oic/__init__.py 66.43% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8ce26...dde60f4. Read the comment docs.

@rohe rohe merged commit 85f803b into master Oct 18, 2019
@rohe rohe deleted the endsession_state branch October 18, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants