Refactor method signature of MethodHandler.Factory.create #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
refactor-constructor-of-ParseHandlerByName
branch
from
038bf62
to
abc936a
Compare
wplong11
changed the title
wplong11
force-pushed
the
refactor-constructor-of-ParseHandlerByName
branch
3 times, most recently
from
2b8f388
to
8c036a7
Compare
velo
approved these changes
Nov 6, 2022
|
@velo Please rerun the ci pipeline |
can't....
did you block circle CI or have anything special on your fork? |
wplong11
force-pushed
the
refactor-constructor-of-ParseHandlerByName
branch
from
8c036a7
to
b57e5c9
Compare
|
@velo CI Passed! I signed in to Circle CI again, approved the repo read permission, and synced the master branch of the fork repo with upstream. |
wplong11
force-pushed
the
refactor-constructor-of-ParseHandlerByName
branch
from
b57e5c9
to
c063215
Compare
velo
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to unify value passing style like other values injected into the constructor.