[question] How to use Feign with a JAX-RS interface defining jaxrs.Response as return types #188

bquenin · 2015-02-18T09:46:49Z

Hi,

I'm using Feign with a JAX-RS interface using JAX-RS Response return types (not feign.Response).
For instance:

@Path("/users")
@Produces(MediaType.APPLICATION_JSON)
public interface UserContract {
    @POST
    @Path("/")
    @Consumes(MediaType.APPLICATION_JSON)
    public Response create(User user);

    ...

When using feign and calling the "create" method, it seems that feigns tries to deserialize the jaxrs.Response object from the HTTP reponse.

Well it makes sense since it's the return type but it's obviously not what I expect. What would be the best way to handle jaxrs.Response type with feign ?

Thanks

codefromthecrypt · 2015-02-18T17:15:54Z

Would need some thought. Maybe a custom decoder I suppose.

codefromthecrypt · 2015-02-19T02:04:54Z

Here's a workaround.. wrap your real decoder with this.

final class ResponseDecoder implements Decoder {
  private final Decoder delegate;

  ResponseDecoder(Decoder delegate) {
    this.delegate = delegate;
  }

  @Override
  public Object decode(Response response, Type type) throws IOException {
    if (jaxrs.Response.class.equals(type)) {
      // construct and return.
    }
    return delegate.decode(response, type);
  }
}

bquenin · 2015-02-19T09:50:47Z

Thanks, that's basically the solution I had, just wanted a confirmation.

AjitDas · 2017-11-02T05:30:09Z

@bquenin @adriancole do you have sample to share how you converted feign Response to jaxrs Response with the entity object set into it.

Thanks a lot in advance

import java.io.IOException;
import java.lang.reflect.Type;
import java.util.Collection;
import java.util.Map;

import javax.ws.rs.core.Response.ResponseBuilder;

import feign.Response;
import feign.codec.Decoder;

public class ResponseDecoder implements Decoder {

	private final Decoder delegate;

	public ResponseDecoder(Decoder delegate) {
		this.delegate = delegate;
	}

	@Override
	public Object decode(Response response, Type type) throws IOException {
		
		if (javax.ws.rs.core.Response.class.equals(type)) {
			// construct and return.
			ResponseBuilder responseBuilder = javax.ws.rs.core.Response
					.status(response.status())
					.entity(...................); // need to get the mapped entity object here , calling delegate.decode(response, type) won't help since the type is javax.ws.rs.core.Response here
			for(Map.Entry<String,Collection<String>> entry:response.headers().entrySet()) {
				responseBuilder.header(entry.getKey(), entry.getValue());
			}
			return responseBuilder.build();
		}
		return delegate.decode(response, type);
	}
}

mattmadhavan · 2020-06-07T23:06:25Z

Helo,
I have been stuck on this same issue for two days. Can any of you share the source code please?

mattmadhavan · 2020-06-07T23:16:16Z

Sorry figure it out! Got my entity like below!

	@Override
	public Object decode(Response response, Type type) throws IOException {
		
		if (javax.ws.rs.core.Response.class.equals(type)) {
			
			String bodyStr = IOUtils.toString(response.body().asInputStream(), Charsets.UTF_8);
			// construct and return.
			ResponseBuilder responseBuilder = javax.ws.rs.core.Response
					.status(response.status())
					.entity(bodyStr); // need to get the mapped entity object here , calling delegate.decode(response, type) won't help since the type is javax.ws.rs.core.Response here
			for(Map.Entry<String,Collection<String>> entry:response.headers().entrySet()) {
				responseBuilder.header(entry.getKey(), entry.getValue());
			}
			return responseBuilder.build();
		}
		return delegate.decode(response, type);
	}

velo · 2020-06-08T00:01:25Z

That could be included on the jaxrs module... if you are interest in making a PR, I can review it.

…nse type fixes OpenFeign#188

bquenin closed this as completed Feb 19, 2015

chrste90 pushed a commit to chrste90/feign that referenced this issue Mar 20, 2024

Add JAXRS3Decoder to allow using jakarta.ws.rs.core.Response as respo…

8341538

…nse type fixes OpenFeign#188

chrste90 mentioned this issue Mar 20, 2024

Add JAXRS3Decoder to allow using jakarta.ws.rs.core.Response as respo… #2361

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[question] How to use Feign with a JAX-RS interface defining jaxrs.Response as return types #188

[question] How to use Feign with a JAX-RS interface defining jaxrs.Response as return types #188

bquenin commented Feb 18, 2015

codefromthecrypt commented Feb 18, 2015 via email

codefromthecrypt commented Feb 19, 2015

bquenin commented Feb 19, 2015

AjitDas commented Nov 2, 2017

mattmadhavan commented Jun 7, 2020

mattmadhavan commented Jun 7, 2020 •

edited by velo

velo commented Jun 8, 2020

[question] How to use Feign with a JAX-RS interface defining jaxrs.Response as return types #188

[question] How to use Feign with a JAX-RS interface defining jaxrs.Response as return types #188

Comments

bquenin commented Feb 18, 2015

codefromthecrypt commented Feb 18, 2015 via email

codefromthecrypt commented Feb 19, 2015

bquenin commented Feb 19, 2015

AjitDas commented Nov 2, 2017

mattmadhavan commented Jun 7, 2020

mattmadhavan commented Jun 7, 2020 • edited by velo

velo commented Jun 8, 2020

mattmadhavan commented Jun 7, 2020 •

edited by velo