Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the metrics reported to micrometer when using MicrometerCapability #2248

Open
adispennette opened this issue Nov 27, 2023 · 5 comments
Labels
help wanted Issues we need help with tackling

Comments

@adispennette
Copy link

is there any documentation on what the various metric published by micrometer mean? I am making a lot of guesses but don't actually know for sure what they are relaying.

@velo
Copy link
Member

velo commented Nov 27, 2023

We do need for someone do look under the hood and write proper docs for metrics.

Is pretty much reporting Timers for http client execution, encoding/deconding and overall time from invokation of feign method.

So you can track if a request is slow, and whos to blame

@adispennette
Copy link
Author

Thanks for the comment @velo I am attempting to monitor the connection pools for each connection. I think I have the right metric with feign.Client.count or feign.Feign.count since they seem to be the same thing. I am also looking at injecting a custom okhttp client that has the pool monitor configured in as well. But I do like the other metrics.

@velo
Copy link
Member

velo commented Nov 28, 2023

the count will only diverge when there are retries. 99% of times it will be the same.

@AlexElin
Copy link

In addition it'd be helpful to document metrics published by MicrometerObservationCapability.

@velo
Copy link
Member

velo commented Jan 28, 2024

In addition it'd be helpful to document metrics published by MicrometerObservationCapability.

That would be awesome. Please send a PR, I will make sure to approve it.

@velo velo added the help wanted Issues we need help with tackling label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues we need help with tackling
Projects
None yet
Development

No branches or pull requests

3 participants