From b57e5c99fe7f66d9eb4a6d1c387e4c221d87a7f5 Mon Sep 17 00:00:00 2001
From: Donghyeon Kim <wplong11@users.noreply.github.com>
Date: Sun, 6 Nov 2022 00:33:08 +0900
Subject: [PATCH] Remove necessary parameters from constructor of
 ParseHandlerByName

---
 core/src/main/java/feign/AsyncFeign.java      |  4 +---
 core/src/main/java/feign/Feign.java           |  4 ++--
 core/src/main/java/feign/ReflectiveFeign.java | 10 ----------
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/core/src/main/java/feign/AsyncFeign.java b/core/src/main/java/feign/AsyncFeign.java
index a211fa298..ebde83694 100644
--- a/core/src/main/java/feign/AsyncFeign.java
+++ b/core/src/main/java/feign/AsyncFeign.java
@@ -208,9 +208,7 @@ public AsyncFeign<C> build() {
               propagationPolicy, methodInfoResolver,
               options, decoder, errorDecoder);
       final ParseHandlersByName<C> handlersByName =
-          new ParseHandlersByName<>(contract, options, encoder,
-              decoder, queryMapEncoder,
-              errorDecoder, methodHandlerFactory);
+          new ParseHandlersByName<>(contract, encoder, queryMapEncoder, methodHandlerFactory);
       final ReflectiveFeign<C> feign =
           new ReflectiveFeign<>(handlersByName, invocationHandlerFactory, defaultContextSupplier);
       return new AsyncFeign<>(feign);
diff --git a/core/src/main/java/feign/Feign.java b/core/src/main/java/feign/Feign.java
index d04584594..82d17067a 100644
--- a/core/src/main/java/feign/Feign.java
+++ b/core/src/main/java/feign/Feign.java
@@ -205,8 +205,8 @@ public Feign build() {
               responseInterceptor, logger, logLevel, dismiss404, closeAfterDecode,
               propagationPolicy, options, decoder, errorDecoder);
       ParseHandlersByName<Object> handlersByName =
-          new ParseHandlersByName<>(contract, options, encoder, decoder, queryMapEncoder,
-              errorDecoder, synchronousMethodHandlerFactory);
+          new ParseHandlersByName<>(contract, encoder, queryMapEncoder,
+              synchronousMethodHandlerFactory);
       return new ReflectiveFeign<>(handlersByName, invocationHandlerFactory, () -> null);
     }
   }
diff --git a/core/src/main/java/feign/ReflectiveFeign.java b/core/src/main/java/feign/ReflectiveFeign.java
index 27df1a1db..19ae21b37 100644
--- a/core/src/main/java/feign/ReflectiveFeign.java
+++ b/core/src/main/java/feign/ReflectiveFeign.java
@@ -26,7 +26,6 @@
 import java.util.concurrent.CompletableFuture;
 import feign.InvocationHandlerFactory.MethodHandler;
 import feign.Param.Expander;
-import feign.Request.Options;
 import feign.codec.*;
 import feign.template.UriUtils;
 
@@ -122,28 +121,19 @@ public String toString() {
   static final class ParseHandlersByName<C> {
 
     private final Contract contract;
-    private final Options options;
     private final Encoder encoder;
-    private final Decoder decoder;
-    private final ErrorDecoder errorDecoder;
     private final QueryMapEncoder queryMapEncoder;
     private final MethodHandler.Factory<C> factory;
 
     ParseHandlersByName(
         Contract contract,
-        Options options,
         Encoder encoder,
-        Decoder decoder,
         QueryMapEncoder queryMapEncoder,
-        ErrorDecoder errorDecoder,
         MethodHandler.Factory<C> factory) {
       this.contract = contract;
-      this.options = options;
       this.factory = factory;
-      this.errorDecoder = errorDecoder;
       this.queryMapEncoder = queryMapEncoder;
       this.encoder = checkNotNull(encoder, "encoder");
-      this.decoder = checkNotNull(decoder, "decoder");
     }
 
     public Map<Method, MethodHandler> apply(Target target, C requestContext) {