provide a way to prune type trees #99
Labels
Milestone
Comments
|
I did a quick experiment where I filtered the types included in the "sources" array here: https://github.com/OpenCyphal/pydsdl/blob/master/pydsdl/_namespace.py#L446 but only for the https://github.com/OpenCyphal/pydsdl/blob/master/pydsdl/_namespace.py#L152 Strangely, this did not return a transitive closure. While the target types were found not all of the types they used were included. |
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
Mar 30, 2024
This is a draft PR to review a proposed change to the public APIs for pydsdl. This is non-breaking change that adds an optional named tuple to the `read_namespace` method. This named tuple allows specifying a set of filtering rules to apply when discovering DSDL types from files under a given namespace filetree. The intent is to connect the proposed TypeFilterEngine to the `_construct_dsdl_definitions_from_namespace` method after it creates a `DSDLDefinition` to apply the initial filtering of the target type. From there I need to figure out how to mark that selected type and its transitive dependencies as either weakly-excluded or strongly-included and detect any conflict where user provided rules conflict as processing proceeds. Any advice as to where I could best work with a tree-representation ahead of any expensive processing would be appreciated.
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
Mar 31, 2024
This is a draft PR to review a proposed change to the public APIs for pydsdl. This is non-breaking change that adds an optional set of visitors allowing users to implement filters. This also allows for new visitor types to be defined in the future without further API changes.
Closed
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
Mar 31, 2024
This is a draft PR to review a proposed change to the public APIs for pydsdl. This is non-breaking change that adds an optional set of visitors allowing users to implement filters. This also allows for new visitor types to be defined in the future without further API changes.
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
Apr 8, 2024
This is a draft PR to review a proposed change to the public APIs for pydsdl. This is non-breaking change that adds a new public method and datatype ## New Method read_files - a file-oriented entry point to the front end. This takes a list of target DSDL files allowing the user to maintain an explicit list instead of depending on globular filesystem discovery. ## New Datatype DsdlFile – We define and publish a new abstract data type that encapsulates all the information collected about and from a given dsdl file. This allows a backend to associate datatypes with files for the purposes of managing dependencies (e.g. this would allow the creation of .d files by a back end).
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
Apr 14, 2024
thirtytwobits
added a commit
to thirtytwobits/pydsdl
that referenced
this issue
May 25, 2024
This is a draft PR to review a proposed change to the public APIs for pydsdl. This is non-breaking change that adds a new public method and datatype read_files - a file-oriented entry point to the front end. This takes a list of target DSDL files allowing the user to maintain an explicit list instead of depending on globular filesystem discovery. DsdlFile – We define and publish a new abstract data type that encapsulates all the information collected about and from a given dsdl file. This allows a backend to associate datatypes with files for the purposes of managing dependencies (e.g. this would allow the creation of .d files by a back end).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently pydsdl simply discovers all dsdl types under a given root folder. For large projects this presents a problem where a significant number of types may exist under a root but a given consumer/producer only uses a small subset of them.
This issue is to provide a way to select target types which become leaf-nodes allowing all other branches to be pruned.
For example, adding a
target types: Optional[List[str]]argument topydsdl.read_namespacewould provide the right interface to enable this in consumers like Nunavut.The text was updated successfully, but these errors were encountered: