Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release polishing #236

Merged
merged 3 commits into from Jul 12, 2021
Merged

Pre-release polishing #236

merged 3 commits into from Jul 12, 2021

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Jul 11, 2021

This is a catch-all PR for anything I find while preparing for the release. Nothing that should affect already released functionality.

Changes:

  • Oklab and Oklch no longer implements ColorDifference, since I can't find any sign of CIEDE2000 being correct there.
  • Separated the first sentence for named gradients as its own paragraph. This makes nicer looking docs.
  • Added an example of the difference between "naive" randomization and our implementation.

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Jul 11, 2021
@Ogeon
Copy link
Owner Author

Ogeon commented Jul 11, 2021

I have also started writing the release blog post. It's a work in progress over at Ogeon/Ogeon.github.io#6, in case anyone want to proof read or remind me of something important.

@github-actions
Copy link

Benchmark for 58cc0ee

Click to view benchmark
Test PR Benchmark Master Benchmark %
Cie family/lab to lch 2.6±0.17µs 2.5±0.16µs +4.00%
Cie family/lab to xyz 732.2±37.75ns 732.5±42.58ns -0.04%
Cie family/lch to lab 2.6±0.21µs 2.6±0.21µs 0.00%
Cie family/linsrgb to xyz 3.2±0.31µs 3.2±0.18µs 0.00%
Cie family/xyz to lab 8.0±0.32µs 8.1±0.52µs -1.23%
Cie family/xyz to yxy 573.1±30.53ns 571.6±29.79ns +0.26%
Cie family/yxy to xyz 540.8±34.76ns 526.5±33.86ns +2.72%
Matrix functions/matrix_inverse 11.0±0.84ns 10.9±0.72ns +0.92%
Matrix functions/multiply_3x3 9.3±0.52ns 8.9±0.39ns +4.49%
Matrix functions/multiply_rgb_to_xyz 3.8±0.17ns 3.7±0.25ns +2.70%
Matrix functions/multiply_xyz 3.8±0.19ns 3.8±0.15ns 0.00%
Matrix functions/multiply_xyz_to_rgb 3.8±0.26ns 3.7±0.19ns +2.70%
Matrix functions/rgb_to_xyz_matrix 19.7±1.26ns 19.4±1.00ns +1.55%
Rgb family/hsl to hsv 621.6±29.85ns 625.0±27.32ns -0.54%
Rgb family/hsl to linear hsl 7.7±0.33µs 7.9±0.54µs -2.53%
Rgb family/hsl to rgb 1938.0±162.59ns 1861.1±84.02ns +4.13%
Rgb family/hsv to hsl 960.2±67.91ns 913.9±44.70ns +5.07%
Rgb family/hsv to hwb 229.8±14.70ns 239.0±18.40ns -3.85%
Rgb family/hsv to linear hsv 7.4±0.38µs 7.4±0.49µs 0.00%
Rgb family/hsv to rgb 1840.8±110.18ns 1805.4±81.53ns +1.96%
Rgb family/hwb to hsv 534.7±25.96ns 525.5±23.21ns +1.75%
Rgb family/hwb to linear hwb 8.5±0.37µs 8.5±0.42µs 0.00%
Rgb family/linear hsl to hsl 8.0±0.39µs 7.8±0.36µs +2.56%
Rgb family/linear hsv to hsv 7.9±0.55µs 7.8±0.47µs +1.28%
Rgb family/linear hwb to hwb 8.9±0.54µs 9.0±0.55µs -1.11%
Rgb family/linsrgb to rgb 4.1±0.21µs 4.1±0.24µs 0.00%
Rgb family/linsrgb_f32 to rgb_u8 5.4±0.34µs 5.3±0.27µs +1.89%
Rgb family/rgb to hsl 752.9±39.48ns 749.0±35.46ns +0.52%
Rgb family/rgb to hsv 547.0±32.74ns 545.0±28.89ns +0.37%
Rgb family/rgb to linsrgb 4.3±0.23µs 4.4±0.27µs -2.27%
Rgb family/rgb_u8 to linsrgb_f32 4.5±0.28µs 4.6±0.26µs -2.17%
Rgb family/xyz to linsrgb 5.9±0.29µs 5.9±0.33µs 0.00%

@github-actions
Copy link

Benchmark for 6d4b4a6

Click to view benchmark
Test PR Benchmark Master Benchmark %
Cie family/lab to lch 3.0±0.00µs 3.0±0.00µs 0.00%
Cie family/lab to xyz 817.6±8.19ns 818.2±0.87ns -0.07%
Cie family/lch to lab 1893.8±3.55ns 2.1±0.00µs -9.82%
Cie family/linsrgb to xyz 3.2±0.01µs 3.2±0.01µs 0.00%
Cie family/xyz to lab 9.1±0.02µs 9.1±0.02µs 0.00%
Cie family/xyz to yxy 617.7±5.44ns 544.6±0.30ns +13.42%
Cie family/yxy to xyz 527.8±0.38ns 528.0±0.43ns -0.04%
Matrix functions/matrix_inverse 11.1±0.01ns 11.0±0.01ns +0.91%
Matrix functions/multiply_3x3 8.1±0.01ns 9.1±0.01ns -10.99%
Matrix functions/multiply_rgb_to_xyz 4.1±0.00ns 3.6±0.00ns +13.89%
Matrix functions/multiply_xyz 4.1±0.00ns 4.1±0.06ns 0.00%
Matrix functions/multiply_xyz_to_rgb 4.1±0.01ns 3.6±0.00ns +13.89%
Matrix functions/rgb_to_xyz_matrix 21.5±0.05ns 21.5±0.02ns 0.00%
Rgb family/hsl to hsv 620.1±0.52ns 620.5±0.49ns -0.06%
Rgb family/hsl to linear hsl 8.1±0.01µs 8.2±0.01µs -1.22%
Rgb family/hsl to rgb 2.1±0.00µs 2.1±0.00µs 0.00%
Rgb family/hsv to hsl 910.0±2.62ns 1030.2±2.98ns -11.67%
Rgb family/hsv to hwb 230.0±0.15ns 230.2±0.18ns -0.09%
Rgb family/hsv to linear hsv 7.6±0.01µs 7.6±0.01µs 0.00%
Rgb family/hsv to rgb 2.1±0.00µs 2.1±0.00µs 0.00%
Rgb family/hwb to hsv 478.6±0.36ns 478.0±0.36ns +0.13%
Rgb family/hwb to linear hwb 9.3±0.01µs 9.3±0.01µs 0.00%
Rgb family/linear hsl to hsl 8.7±0.06µs 8.7±0.01µs 0.00%
Rgb family/linear hsv to hsv 8.2±0.01µs 8.2±0.02µs 0.00%
Rgb family/linear hwb to hwb 10.0±0.00µs 10.0±0.01µs 0.00%
Rgb family/linsrgb to rgb 4.0±0.00µs 3.9±0.00µs +2.56%
Rgb family/linsrgb_f32 to rgb_u8 5.4±0.01µs 5.4±0.01µs 0.00%
Rgb family/rgb to hsl 741.8±0.69ns 741.8±0.63ns 0.00%
Rgb family/rgb to hsv 565.7±0.48ns 565.8±0.41ns -0.02%
Rgb family/rgb to linsrgb 4.3±0.00µs 4.3±0.00µs 0.00%
Rgb family/rgb_u8 to linsrgb_f32 4.6±0.00µs 4.6±0.00µs 0.00%
Rgb family/xyz to linsrgb 7.0±0.03µs 7.0±0.00µs 0.00%

@github-actions
Copy link

Benchmark for 222cce8

Click to view benchmark
Test PR Benchmark Master Benchmark %
Cie family/lab to lch 2.6±0.03µs 2.6±0.00µs 0.00%
Cie family/lab to xyz 719.6±0.74ns 721.0±0.58ns -0.19%
Cie family/lch to lab 1817.2±34.29ns 1845.8±36.86ns -1.55%
Cie family/linsrgb to xyz 3.1±0.04µs 2.8±0.00µs +10.71%
Cie family/xyz to lab 9.4±0.01µs 9.1±0.01µs +3.30%
Cie family/xyz to yxy 544.8±1.16ns 617.2±0.48ns -11.73%
Cie family/yxy to xyz 465.4±0.26ns 470.7±2.32ns -1.13%
Matrix functions/matrix_inverse 9.7±0.03ns 9.7±0.01ns 0.00%
Matrix functions/multiply_3x3 8.4±0.00ns 8.1±0.00ns +3.70%
Matrix functions/multiply_rgb_to_xyz 3.6±0.01ns 4.1±0.02ns -12.20%
Matrix functions/multiply_xyz 3.6±0.01ns 3.6±0.00ns 0.00%
Matrix functions/multiply_xyz_to_rgb 3.6±0.01ns 3.6±0.00ns 0.00%
Matrix functions/rgb_to_xyz_matrix 19.0±0.11ns 21.5±0.01ns -11.63%
Rgb family/hsl to hsv 547.2±1.30ns 548.1±0.31ns -0.16%
Rgb family/hsl to linear hsl 8.1±0.01µs 7.2±0.04µs +12.50%
Rgb family/hsl to rgb 1869.7±3.00ns 2.1±0.00µs -10.97%
Rgb family/hsv to hsl 901.2±7.03ns 880.1±4.16ns +2.40%
Rgb family/hsv to hwb 203.1±0.51ns 203.0±0.17ns +0.05%
Rgb family/hsv to linear hsv 6.7±0.03µs 6.8±0.01µs -1.47%
Rgb family/hsv to rgb 1835.8±9.55ns 1836.4±5.51ns -0.03%
Rgb family/hwb to hsv 421.3±1.14ns 421.1±0.60ns +0.05%
Rgb family/hwb to linear hwb 8.3±0.05µs 8.2±0.07µs +1.22%
Rgb family/linear hsl to hsl 7.6±0.07µs 7.6±0.04µs 0.00%
Rgb family/linear hsv to hsv 7.2±0.08µs 8.3±0.01µs -13.25%
Rgb family/linear hwb to hwb 8.8±0.02µs 8.8±0.03µs 0.00%
Rgb family/linsrgb to rgb 3.5±0.01µs 3.5±0.03µs 0.00%
Rgb family/linsrgb_f32 to rgb_u8 4.8±0.02µs 4.7±0.04µs +2.13%
Rgb family/rgb to hsl 659.8±2.43ns 657.1±2.58ns +0.41%
Rgb family/rgb to hsv 505.8±0.52ns 503.9±0.88ns +0.38%
Rgb family/rgb to linsrgb 3.8±0.02µs 4.3±0.00µs -11.63%
Rgb family/rgb_u8 to linsrgb_f32 4.1±0.01µs 4.6±0.00µs -10.87%
Rgb family/xyz to linsrgb 6.2±0.03µs 7.0±0.00µs -11.43%

@Ogeon
Copy link
Owner Author

Ogeon commented Jul 12, 2021

bors r+

@Ogeon Ogeon marked this pull request as ready for review July 12, 2021 14:32
@bors
Copy link
Contributor

bors bot commented Jul 12, 2021

Build succeeded:

@bors bors bot merged commit ad33812 into master Jul 12, 2021
@bors bors bot deleted the pre_release_polish branch July 12, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant