Correct scaling on random distribution of Lab/Lch #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I finally got around to playing with the "random" feature. I was curious what the distributions looked like for each space and generated an image of random pixels for each one. Something seemed off with Lab/Lch as you can see in the image. When I checked the code, I realized a factor was overlooked or lost along the way. The range of Lab/Lch is treated as 0.0 to 1.0 instead of 0.0 to 100.0. The other spaces seemed to have appropriate results. Left side is before the fix, right side is this PR. Top is Lab, bottom is Lch.
|
|
Ah yes. Good catch! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the proper scaling factor for random color distribution in Lab/Lch.
Lab/Lch brightness was being treated as 0-1 instead of 0-100.