Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot default white point in alpha type aliases #177

Closed
piegamesde opened this issue Apr 17, 2020 · 1 comment · Fixed by #190
Closed

Forgot default white point in alpha type aliases #177

piegamesde opened this issue Apr 17, 2020 · 1 comment · Fixed by #190
Labels
defect Something that isn't as or doesn't work as intended

Comments

@piegamesde
Copy link

Lch is a valid type, but Lcha is not. I have to specify the white point with Lcha<white_point::D65>. In the type alias definition, type Lcha<Wp, T = f32> = Alpha<Lch<Wp, T>, T>; should be changed to type Lcha<Wp = D65, T = f32> = Alpha<Lch<Wp, T>, T>; to remove that inconsistency.

I haven't checked all color types, but at least the Laba type suffers from this as well.

@Ogeon
Copy link
Owner

Ogeon commented Apr 18, 2020

Thanks for pointing this out!

I don't remember if there was a reason for doing it that way or if it was an just oversight. Most likely a mistake or some reasoning that it would be inherited from whatever other color space is used. That last part is probably more inconvenient than helpful.

@Ogeon Ogeon added the defect Something that isn't as or doesn't work as intended label Apr 18, 2020
@bors bors bot closed this as completed in 91ff1d4 Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something that isn't as or doesn't work as intended
Projects
None yet
2 participants