Add some missing From impls between Srgb and LinSrgb types
#137
Conversation
|
Hi! There were no particular reasons for not adding these, other than that I tend to not add too many convenience things from the start. There are a lot of possible combinations that can be made and it becomes hard to keep track of all of them after a while. But these are pretty standard so I see no harm in having them. |
palette/src/rgb/mod.rs
Outdated
| fn from(lin_srgb: LinSrgb<T>) -> Self { | ||
| let color = lin_srgb.into(); | ||
| let alpha = U::max_intensity(); | ||
| Alpha { color, alpha } |
There was a problem hiding this comment.
Hmm... You should not have to construct the Alpha like this. You should be able to use from_linear and into_format on these too. Otherwise that's also a hole in the API.
|
Hi! Just checking to see if you are still interested in picking this up again. My only reason for not merging straight away is that I would like to know if it can be implemented in terms if |
I ran into an issue downstream when attempting to write a generic function that would accept any type of colour that may be converted to `Srgb<T>`. I noticed implementations seemed to exist for all of the colour types I cared about apart from `LinSrgb<T>`, so I thought I'd implement the missing conversions and open a PR! Let me know if there's a reason that these have been omitted that I'm overlooking, or if you have a better way in mind for adding these conversions! Unfortunately, conversions between entirely generic `Rgb<S, T>` and `Rgb<St, U>` are impossible due to the existing blanket `impl From<T> for T`, but adding individual implementations for the RGB standards we care about doesn't seem so bad :)
This improves some conversion trait implementations by taking advantage
of the existing `{into/from}_{linear/format}` API as recommended by
@Ogeon.
mitchmindtree
force-pushed
the
srgb_conv
branch
from
0f6f359
to
e538ab1
Compare
|
Sorry about the delay @Ogeon, I think I've now addressed the issues you mentioned! |
|
No worries, this looks great! Thanks! |
|
bors r+ |
137: Add some missing `From` impls between `Srgb` and `LinSrgb` types r=Ogeon a=mitchmindtree I ran into an issue downstream when attempting to write a generic function that would accept any type of colour that may be converted to `Srgb<T>`. I noticed implementations seemed to exist for all of the colour types I cared about apart from `LinSrgb<T>`, so I thought I'd implement the missing conversions and open a PR! Let me know if there's a reason that these have been omitted that I'm overlooking, or if you have a better way in mind for adding these conversions! Unfortunately, conversions between entirely generic `Rgb<S, T>` and `Rgb<St, U>` are impossible due to the existing blanket `impl From<T> for T`, but adding individual implementations for the RGB standards we care about doesn't seem so bad :) Co-authored-by: mitchmindtree <mitchell.nordine@gmail.com>
Build succeeded |
I ran into an issue downstream when attempting to write a generic
function that would accept any type of colour that may be converted to
Srgb<T>. I noticed implementations seemed to exist for all of thecolour types I cared about apart from
LinSrgb<T>, so I thought I'dimplement the missing conversions and open a PR!
Let me know if there's a reason that these have been omitted that I'm
overlooking, or if you have a better way in mind for adding these
conversions! Unfortunately, conversions between entirely generic
Rgb<S, T>andRgb<St, U>are impossible due to the existing blanketimpl From<T> for T, but adding individual implementations for the RGBstandards we care about doesn't seem so bad :)