Remove the color enum #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogeon
requested changes
Oct 2, 2018
palette/examples/color_scheme.rs
Outdated
| @@ -93,8 +93,8 @@ fn main() { | |||
| .and_then(|r| r.parse().ok()) | |||
| .expect("the blue channel must be a number in the range [0-255]"); | |||
|
|
|||
| let primary: Color = Srgb::new(red, green, blue) | |||
| .into_format() | |||
| let primary: Hsv = Srgb::new(red, green, blue) | |||
There was a problem hiding this comment.
This should be Lch to achieve the same results.
There was a problem hiding this comment.
Ah yes, I already thought that it had to be the color type I used
There was a problem hiding this comment.
This kind of illustrates one of the reasons why I wanted to remove it. The selling point for Color was that it would pick the most suitable color space for the task. The downside was that it would hide this choice and could produce surprising results.
palette/examples/readme_examples.rs
Outdated
| let lighter = color.lighten(0.1); | ||
| let desaturated = color.desaturate(0.5); | ||
| let desaturated = Hsv::from(color).desaturate(0.5); |
There was a problem hiding this comment.
This should also be Lch to achieve the same results.
|
Okay, the example now has the correct color and I've updated the Readme 👌 |
Ogeon
approved these changes
Oct 2, 2018
|
Updated the description |
|
Thanks! bors: r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2018
119: Remove the color enum r=Ogeon a=Veykril This PR removes the color type enum as described in #72. I do not know if this has any side effects tough, everything compiles fine on my end, tests and examples compile and run as well. The only difference i noticed is in the `readme_examples/readme_manipulation` example part. The latter two colors arent the same but im not sure why. Closes #72. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the color type enum as described in #72. I do not know if this has any side effects tough, everything compiles fine on my end, tests and examples compile and run as well. The only difference i noticed is in the
readme_examples/readme_manipulationexample part. The latter two colors arent the same but im not sure why.Closes #72.