Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement assign ops #118

Merged
merged 1 commit into from Sep 18, 2018
Merged

Implement assign ops #118

merged 1 commit into from Sep 18, 2018

Conversation

Veykril
Copy link
Contributor

@Veykril Veykril commented Sep 18, 2018

Closes #94.

@Ogeon
Copy link
Owner

Ogeon commented Sep 18, 2018

Nice and straight forward! Thanks for doing some drive-by cleaning on the output types as well!

bors r+

bors bot added a commit that referenced this pull request Sep 18, 2018
@bors @Veykril
Merge #118
2abed01 
118: Implement assign ops r=Ogeon a=Veykril

Closes #94.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 18, 2018

Timed out

@Ogeon
Copy link
Owner

Ogeon commented Sep 18, 2018

bors r+

bors bot added a commit that referenced this pull request Sep 18, 2018
@bors @Veykril
Merge #118
d1acf02 
118: Implement assign ops r=Ogeon a=Veykril

Closes #94.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@Ogeon
Copy link
Owner

Ogeon commented Sep 18, 2018

Looks like I was too eager. It seems to be building as expected now.

@bors
Copy link
Contributor

bors bot commented Sep 18, 2018

Build succeeded

@bors bors bot merged commit 70ea4b3 into Ogeon:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Veykril @Ogeon