Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the readme symlinks #116

Closed
Ogeon opened this issue Aug 28, 2018 · 1 comment · Fixed by #142
Closed

Fix the readme symlinks #116

Ogeon opened this issue Aug 28, 2018 · 1 comment · Fixed by #142
Labels
documentation Related to things like README or the API documentation.

Comments

@Ogeon
Copy link
Owner

Ogeon commented Aug 28, 2018

The README.md files are supposed to be linked to the one in the project root, but something has made the link disappear from git, somehow, so now they are out of sync. This should be fixed.
@Ogeon
Copy link
Owner Author

Ogeon commented Aug 10, 2019

...or stop symlinking.

@Ogeon Ogeon added the documentation Related to things like README or the API documentation. label Aug 10, 2019
@Ogeon Ogeon mentioned this issue Aug 11, 2019
Merged
bors bot added a commit that referenced this issue Aug 11, 2019
@bors @Ogeon
Merge #142
c81b3cd 
142: Make libm optional r=Ogeon a=Ogeon

I decided to do this to avoid having it as an unused dependency and also to hopefully be compatible with a future release of `num_traits`, where they seem to be planning the same kind of construct, judging by rust-num/num-traits#99. A transition to using `num_trait` for both cases will hopefully be seamless for the users after this.

I think this also fixes #116.

Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>
@bors bors bot closed this as completed in #142 Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Related to things like README or the API documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make libm optional Ogeon/palette
1 participant
@Ogeon