Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSLuv support #112

Closed
masonium opened this issue Jul 31, 2018 · 6 comments · Fixed by #225
Closed

HSLuv support #112

masonium opened this issue Jul 31, 2018 · 6 comments · Fixed by #225

Comments

@masonium
Copy link
Contributor

HSLuv is a more intuitive version of CIELAB Lch, designed for programmatic color generation. I would be happy to attempt an implementation, if you're interested in adding it to palette.
@Ogeon Ogeon added this to the 0.5.0 milestone Jul 31, 2018
@Ogeon
Copy link
Owner

Ogeon commented Jul 31, 2018

It looks like a useful format, so go ahead! Let me know if you want to discuss anything along the way, or if you change your mind. I'm also usually encouraging opening early pull requests for feedback during the process.

@Benjamin-L
Copy link

I'm going to try writing up an implementation for this, unless @masonium is still interested/working on it.

@masonium
Copy link
Contributor Author

Somehow I completely missed @Ogeon 's reply :-/, so I never started working on it. @Benjamin-L feel free to take it form me.

@Ogeon
Copy link
Owner

Ogeon commented Dec 10, 2018

I'm happy with this arrangement if you two are. Feel free to come with feedback too, @masonium, when there's a pull request. It's nice to have more than just my eyes on it.

@Ogeon Ogeon removed this from the 0.5.0 milestone Jul 7, 2019
@Artoria2e5
Copy link

It's based on CIE LUV, not CIE LAB. Someone has to do the LUV part first.

@masonium
Copy link
Contributor Author

masonium commented May 7, 2021

Very late, but I submitted PR #219 to address this issue.

@Ogeon Ogeon mentioned this issue May 23, 2021
Merged
@bors bors bot closed this as completed in fad9c87 May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Hsluv support masonium/palette
4 participants
@masonium @Ogeon @Artoria2e5 @Benjamin-L