Update image and approx crate dependency #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
changed the title
Ogeon
requested changes
May 28, 2018
palette/src/equality.rs
Outdated
| fn default_max_ulps() -> u32 { | ||
| T::default_max_ulps() | ||
| fn abs_diff_ne(&self, other: &Self, epsilon: T::Epsilon) -> bool { | ||
| $( self.$element.abs_diff_ne(&other.$element, epsilon) )&&+ |
There was a problem hiding this comment.
I think these should be delimited with ||, since it would be the inverse of abs_diff_eq. Same for the other *_ne implementations.
There was a problem hiding this comment.
You're right that should be ||, looks it was implemented wrong previously as well because the *_ne were using &&. I just adapted that by accident. Fixed it now if I didnt miss anything.
There was a problem hiding this comment.
Oops, good thing it was discovered then.
Ogeon
approved these changes
May 28, 2018
|
I think that was all. Great! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101 and closes #100. I accidentally put both pull requests together.