Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commentsids part to maindocumentpart relationship #928

Merged
merged 2 commits into from
May 13, 2021
Merged

Add commentsids part to maindocumentpart relationship #928

merged 2 commits into from
May 13, 2021

Conversation

tomjebo
Copy link
Collaborator

@tomjebo tomjebo commented Apr 28, 2021

No description provided.

@twsouthwick twsouthwick reopened this Apr 29, 2021
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought, but LGTM

{
public static class ITestOutputHelperExtenstion
{
static public void WriteObjectToTempFile(this ITestOutputHelper output, object obj)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can mark this with the attribute [Conditional("DEBUG")] and then you don't need to if/def - it'll only happen on debug

@tomjebo tomjebo merged commit 7a9efbf into dotnet:main May 13, 2021
@tomjebo tomjebo deleted the commentsids branch October 26, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants