Make CT_Person contact property "obsolete" with note for future removal. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomjebo
commented
Mar 23, 2021
tomjebo
commented
- remove validation requirement for CT_Person contact attribute.
twsouthwick
requested changes
Mar 23, 2021
src/DocumentFormat.OpenXml/GeneratedCode/schemas_microsoft_com_office_word_2012_wordml.g.cs
Show resolved
Hide resolved
added 3 commits
March 24, 2021 14:32
tomjebo
changed the title
twsouthwick
requested changes
Mar 25, 2021
|
Please update hte README with this change |
twsouthwick
requested changes
Mar 26, 2021
| /// </summary> | ||
| [Obsolete("This property will not persist to the document and will be removed in a future version")] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public StringValue? Contact; |
There was a problem hiding this comment.
This is a field - you want public StringValue? Contact {get; set;}
twsouthwick
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.