-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 0/1 for boolean cell values #890
Conversation
@tomjebo Can you verify that a |
From MS-OI29500 2.1.659: ...If the cell contains a Boolean, the value shall be 1 to specify true and 0 to specify false. |
So can it be |
Yes, but they MUST be lower case. Excel reads this as lower case "true" or "false" but will only write as "0" or "1". Excel will throw a message dialog and ask to "correct" the underlying XML if the type is "b" and the value is anything but "0", "1", "true", or "false". |
Thanks @mkorsukov for the comments! |
@tomjebo can you take another look and approve if it looks good? I'd like to get this out as a 2.12.3 release |
Thanks, this actually highlighted some issues in ClosedXML. We were writing out Boolean values using propercasing. Nobody every complained, though. |
Fixes #887