Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office 2019 Updates #882

Merged
merged 6 commits into from
Feb 17, 2021
Merged

Office 2019 Updates #882

merged 6 commits into from
Feb 17, 2021

Conversation

tomjebo
Copy link
Collaborator

@tomjebo tomjebo commented Feb 10, 2021

update the generated code from the schema processor (backend)
add code to include new namespaces

@@ -16,7 +16,7 @@ namespace DocumentFormat.OpenXml.Office2019.Drawing.Diagram11
{
/// <summary>
/// <para>Defines the NumberDiagramInfoList Class.</para>
/// <para>This class is available in Office 2007 or above.</para>
/// <para>This class is available in Office 2019 or above.</para>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the interop documentation we normally use "is supported in 20xx and later" or use "is not supported in 20xx or later". So if supported, use "and later", if not supported, use "or later".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the meaning is the same but I'll defer to others' opinions. I don't see a really strong need except to match Open Specs docs exact wording. Am I missing anything else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that you used the usual wording in other files, so would suggest to make this the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto generated and something I actually just put in. We can definitely change it to match standard wordage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we agreed to make this change in master first and then merge it to the Office2019 project.

Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomjebo tomjebo merged commit 7b238ce into dotnet:office2019 Feb 17, 2021
tomjebo added a commit that referenced this pull request Feb 24, 2021
* This commit adds support for the Office 2019 file format types, elements and attributes.
tomjebo added a commit that referenced this pull request Feb 24, 2021
Update changelog for PR #882 merge
@tomjebo tomjebo deleted the o19schemas branch October 26, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants