-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office 2019 Updates #882
Office 2019 Updates #882
Conversation
@@ -16,7 +16,7 @@ namespace DocumentFormat.OpenXml.Office2019.Drawing.Diagram11 | |||
{ | |||
/// <summary> | |||
/// <para>Defines the NumberDiagramInfoList Class.</para> | |||
/// <para>This class is available in Office 2007 or above.</para> | |||
/// <para>This class is available in Office 2019 or above.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the interop documentation we normally use "is supported in 20xx and later" or use "is not supported in 20xx or later". So if supported, use "and later", if not supported, use "or later".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the meaning is the same but I'll defer to others' opinions. I don't see a really strong need except to match Open Specs docs exact wording. Am I missing anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that you used the usual wording in other files, so would suggest to make this the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto generated and something I actually just put in. We can definitely change it to match standard wordage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we agreed to make this change in master first and then merge it to the Office2019 project.
...tFormat.OpenXml/GeneratedCode/schemas_microsoft_com_office_spreadsheetml_2017_richdata2.g.cs
Show resolved
Hide resolved
src/DocumentFormat.OpenXml/GeneratedCode/schemas_openxmlformats_org_drawingml_2006_main.g.cs
Show resolved
Hide resolved
...umentFormat.OpenXml/GeneratedCode/schemas_openxmlformats_org_wordprocessingml_2006_main.g.cs
Show resolved
Hide resolved
...umentFormat.OpenXml/GeneratedCode/schemas_openxmlformats_org_wordprocessingml_2006_main.g.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update changelog for PR #882 merge
update the generated code from the schema processor (backend)
add code to include new namespaces