Openxmlreader ignorews option #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lklein53
force-pushed
the
openxmlreader-ignorews-option
branch
from
a25e9e7
to
51296aa
Compare
lklein53
force-pushed
the
openxmlreader-ignorews-option
branch
from
51296aa
to
c0ba6c5
Compare
lklein53
changed the title
twsouthwick
requested changes
Jan 19, 2021
test/DocumentFormat.OpenXml.Tests/ofapiTest/OpenXmlReaderTest.cs
Outdated
Show resolved
Hide resolved
test/DocumentFormat.OpenXml.Tests/ofapiTest/OpenXmlReaderTest.cs
Outdated
Show resolved
Hide resolved
test/DocumentFormat.OpenXml.Tests/ofapiTest/OpenXmlReaderTest.cs
Outdated
Show resolved
Hide resolved
added 2 commits
January 20, 2021 08:08
Introduce new constructor Restore old constructors
lklein53
force-pushed
the
openxmlreader-ignorews-option
branch
from
d0b9eda
to
a59969a
Compare
twsouthwick
requested changes
Jan 22, 2021
Adjust comment Restore previous whitespace handling
Thanks for the review. Sorry messed that up. Wasn't careful enough doing the changes |
twsouthwick
approved these changes
Jan 22, 2021
Hi, sadly today I discovered an issue with the changes. In the case where an xml file has whitespace after the actual content for example: <document>
<body>
...
</body>
</document> (space after the >)the OpenXmlPartReader will crash with an InvalidOperationException as it is trying to get information for a child element with an empty stack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes discussed in #848 @twsouthwick