Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a choice in Dynamic Typeahead Search still shows errorMessage string meant for when no choice is selected. #1213

Open
SandeepGamot opened this issue Mar 26, 2024 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@SandeepGamot
Copy link

Repro Steps:

  1. Implement a simple dynamic typeahead search card following the below shape
{
  "type": "Input.ChoiceSet",
  "isRequired": true,
  "errorMessage": "Select atleast one user",
  "id": "users",
  "choices": "${users}",
  "isMultiSelect": true,
  "placeholder": "Select user(s)",
  "value": "${defaultUsers}",
  "style": "filtered",
  "choices.data": {
    "type": "Data.Query",
    "dataset": "users"
  }
}
  1. Start the bot in MS-Teams Web app using Chrome (any browser should do) and navigate to the dynamic typeahead search component
  2. Select any choice and click on submit
  3. See the bug where the string specified in errorMessage field show up. In this case "Select atleast one user".

Kapture 2024-03-26 at 16 18 16

Expected Behaviour

There shouldn't be an error when at least one choice is made and the submit button is clicked. Only when no choice is made and submit button is clicked we show the error.

According to related closed issue #868 it was resolved but currently it's happening in MS-teams Web for nodejs based projects.

@Meghana-MSFT
Copy link

Meghana-MSFT commented Mar 26, 2024

@SandeepGamot - Thank you for reporting this, we will check this and get back to you. It looks like your issue is similar to MicrosoftDocs/msteams-docs#10533. Could you please confirm?

@SandeepGamot
Copy link
Author

SandeepGamot commented Mar 27, 2024

@Meghana-MSFT the underlying bug is same in the issue you mentioned. Only difference is in the framework used, they're using C# and we're using Node.

@Meghana-MSFT
Copy link

Thank you for your confirmation. We will keep you posted on the bug fix updates.

@SandeepGamot
Copy link
Author

Thanks for the update @Meghana-MSFT
Any rough ETA on this?

@Meghana-MSFT
Copy link

Unfortunately, we do not have any ETA to share. We are following up for updates and we will keep you posted.

@SandeepGamot
Copy link
Author

Hi @Meghana-MSFT any updates?

@Meghana-MSFT
Copy link

Unfortunately, we do not have any updates to share. We will keep you posted.

@SandeepGamot
Copy link
Author

SandeepGamot commented Apr 15, 2024

Hey @Meghana-MSFT any new updates?

@Meghana-MSFT
Copy link

@SandeepGamot - We are checking this internally with the engineering team. We will keep you posted once the fix has reached public rings.

@SandeepGamot
Copy link
Author

Hi @Meghana-MSFT sorry to bother again. Any new updates?

@Meghana-MSFT
Copy link

@SandeepGamot - Apologies for the inconvenience caused to you. The fix has not reached public rings yet. We will keep you posted.

@ChetanSharma-msft ChetanSharma-msft added bug Something isn't working and removed needs-triage 🔍 labels May 1, 2024
@Meghana-MSFT
Copy link

@SandeepGamot - This bug has been fixed; we verified the fix in both web & Desktop Teams. Its working fine. Could you please check and confirm once.

Web: The client version is 1415/24050307611.
Desktop: You have Microsoft Teams version 24137.2200.2883.9306. The client version is 49/24051703400.

@SandeepGamot
Copy link
Author

Hi @Meghana-MSFT thanks for the update.
Can you also help me with a guide or doc link on how to update my local development server with the web client version you shared. Not able to find anything about this online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants