Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample bot-sso-adaptivecard still using botframeworkadapter which is deprecated #1039

Open
KennethBWSong opened this issue Nov 16, 2023 · 10 comments
Assignees
Labels
bug Something isn't working platform-issue Teams JS issue

Comments

@KennethBWSong
Copy link

Code here:

const adapter = new BotFrameworkAdapter({

@Meghana-MSFT
Copy link

Meghana-MSFT commented Nov 16, 2023

@KennethBWSong - Thank you for reporting this, we will check this and get the sample updated if necessary. Thank you.

PR has raised for this: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1042/files

@KennethBWSong
Copy link
Author

Any updates?

@Meghana-MSFT
Copy link

PR has raised for this: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1042/files. Changes will reflect once the PR is merged.

@KennethBWSong
Copy link
Author

@Meghana-MSFT Seems the PR is merged, and I got following error when debug with Teams Toolkit:
image
image
Do you have idea on what's the reason?

@KennethBWSong
Copy link
Author

@Meghana-MSFT Also, in this sample to get SSO token:
image
type of the card is "application/vnd.microsoft.card.loginRequest" which is different from here. Would you please help to confirm which is the correct way?

@Meghana-MSFT
Copy link

We will check this and get back to you.

@Meghana-MSFT
Copy link

@Meghana-MSFT Seems the PR is merged, and I got following error when debug with Teams Toolkit: image image Do you have idea on what's the reason?

This is a known issue, bug has been raised for this already - MicrosoftDocs/msteams-docs#8584

@ChetanSharma-msft ChetanSharma-msft added the bug Something isn't working label Dec 7, 2023
@KennethBWSong
Copy link
Author

@Meghana-MSFT Any updates on this?

@ChetanSharma-msft ChetanSharma-msft added the platform-issue Teams JS issue label Dec 27, 2023
@ChetanSharma-msft
Copy link
Collaborator

ChetanSharma-msft commented Dec 27, 2023

Hello @KennethBWSong - Sorry for delay in response.
We are actively checking the updates on this issue with engineering team and let you know if any.

@simone-montemezzani-3AP

Any update on this? The samples are really hard to follow in general, let alone when they contain wrong code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-issue Teams JS issue
Projects
None yet
Development

No branches or pull requests

4 participants