Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: staticcheck errors #103

Merged
merged 11 commits into from
Jun 6, 2022
Merged

fix: staticcheck errors #103

merged 11 commits into from
Jun 6, 2022

Conversation

jbristowe
Copy link
Contributor

No description provided.

@jbristowe jbristowe requested a review from a team June 6, 2022 05:01
hnrkndrssn
hnrkndrssn approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of small questions

octopusdeploy/certificate_service_test.go Show resolved Hide resolved
octopusdeploy/utilities.go Show resolved Hide resolved
@jbristowe jbristowe merged commit 9a0c32d into main Jun 6, 2022
@jbristowe jbristowe deleted the fix-staticcheck-errors branch June 6, 2022 06:01
@jbristowe jbristowe restored the fix-staticcheck-errors branch June 6, 2022 06:04
@jbristowe jbristowe deleted the fix-staticcheck-errors branch June 6, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnrkndrssn hnrkndrssn hnrkndrssn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbristowe @hnrkndrssn